Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timelion] Update the removal message to mention the exact version #100994

Merged
merged 5 commits into from
Jun 7, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 31, 2021

Summary

This PR changes the texts referring to Timelion app removal. Specifically,

  • changes the UI notification to mention the minor
  • same for server logs and upgrade assistant
  • change the Timelion docs (embedded on the dashboard section)

There is also a follow-up PR that upgrades the Deprecations section of the 7.10 documentation. #100995

image

Docs preview: https://kibana_100994.docs-preview.app.elstc.co/guide/en/kibana/master/timelion.html

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

@stratoula stratoula added Feature:TimelionApp Team:Visualizations Visualization editors, elastic-charts and infrastructure 7.14 candidate v8.0.0 v7.14.0 release_note:skip Skip the PR/issue when compiling release notes and removed 7.14 candidate labels May 31, 2021
@stratoula stratoula marked this pull request as ready for review May 31, 2021 15:36
@stratoula stratoula requested a review from a team May 31, 2021 15:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested review from KOTungseth and timroes May 31, 2021 15:36
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelion 197.4KB 197.4KB -22.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code owners review, just textual changes, didn't test locally

@stratoula stratoula merged commit 6338a59 into elastic:master Jun 7, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Jun 7, 2021
…lastic#100994)

* [Timelion] Update the removal message to mention the exact version

* Fix typo

Co-authored-by: Kibana Machine <[email protected]>
stratoula added a commit that referenced this pull request Jun 7, 2021
…100994) (#101466)

* [Timelion] Update the removal message to mention the exact version

* Fix typo

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 7, 2021
* master: (90 commits)
  Fix UI breaks on providing long search keyword in 'Search Box' (elastic#101385)
  Adds css class to EuiDescriptionListDescription in order to break word on exception details card (elastic#101481)
  [Lens] Increase timings for drag and drop tests (elastic#101380)
  [Lens] Fix editor react error on configuration panel (elastic#101367)
  [Fleet] Move integrations to a separate app (elastic#99848)
  Fix incorrect message displayed on importing Timeline Templates (elastic#101288)
  [Cases] RBAC (elastic#95058)
  [APM] Visual improvements for new APM layout with left navigation (elastic#101360)
  [master] More precise alerts matching (elastic#99820)
  [Lens] Value in legend (elastic#101353)
  Revert "[Reporting] ILM policy for managing reporting indices (elastic#100130)" (elastic#101358)
  [Discover] Fix header row of data grid in Firefox (elastic#101374)
  Add link to advanced setting in Discover (elastic#101154)
  Url service locators (elastic#101045)
  [Timelion] Update the removal message to mention the exact version (elastic#100994)
  [Security Solution][Detection Engine] Test cases for alias failure test cases where we don't copy aliases correctly (elastic#101437)
  [Event Log] Adding `type_id` to saved object array in event log (elastic#100939)
  [Reporting] Add `location.url` info to console message logs (elastic#101427)
  [Security Solutions][Detection Engine] Fixes timestamp bugs within source indexes when the formats are not ISO8601 format (elastic#101349)
  Improve Task Manager instrumentation (elastic#99160)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TimelionApp release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants